Repository navigation
Stop sending $top to /subscriptions - #131
Merged
Merged
Conversation
teams subscribe list always failed with HTTP 400 ("Query option 'Top'
is not allowed. To allow it, set the 'AllowedQueryOptions' property on
EnableQueryAttribute or QueryValidationSettings."): Graph rejects $top
on /subscriptions, and list_subscriptions has added it since v0.1.0.
Page by @odata.nextLink alone, as channel list and chat members list
already do. Found by the v0.11.0 release smoke; checked live that the
fixed build lists subscriptions where the current one gets the 400.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teams subscribe listhas failed since v0.1.0. Graph rejects$topon/subscriptionswith HTTP 400 ("Query option 'Top' is not allowed"), andlist_subscriptionsalways added it. The v0.11.0 release smoke found it.Fix: page by
@odata.nextLinkalone, using the existingget_paged_without_top, aschannel listandchat members listalready do.--page-sizeis now ignored for this command.Tests:
$topis sent. It fails on the old code path.success: true.🤖 Generated with Claude Code