Skip to content

Document the added support of identifier with OSH jobs - #1168

Closed
betulependule wants to merge 1 commit into
packit:mainfrom
betulependule:osh/identifier-support
Closed

betulependule wants to merge 1 commit into
packit:mainfrom
betulependule:osh/identifier-support

Conversation

@betulependule

Copy link
Copy Markdown
Contributor

Related to #3172

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:57 AM UTC · Completed 8:09 AM UTC

Commit: 3ee67d5 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.97

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Looks good to me


Labels: PR documents OpenScanHub identifier matching for Copr build jobs

Previous run

Looks good to me

Previous run (2)

Review

Findings

Low

  • [admonition formatting consistency] docs/configuration/index.md:847 — The new :::caution Multiple OSH jobs block omits the blank line between the opening directive and the body text. The majority of admonition blocks in this file include a blank line after the opening directive, including the three other :::caution blocks (lines 102, 273, 777). However, at least two existing :::info blocks also omit this blank line, so the pattern is not universal.

  • [incomplete-docs] docs/configuration/upstream/copr_build.md:65 — The identifier key documentation describes it only as a suffix for GitHub check run names. The new caution block in docs/configuration/index.md explains the additional OSH-related significance of identifiers, but copr_build.md does not cross-reference this new behavior. Consider adding a brief note mentioning its role in OSH differential scans, or adding a cross-reference to the main configuration page's new caution block.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Aug 26, 2026
Comment thread docs/configuration/index.md Resolved
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

🤖 Review · ❌ Terminated · Started 11:16 AM UTC · Ended 11:23 AM UTC

Commit: cb243c7 · View workflow run →

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:16 AM UTC · Completed 11:23 AM UTC

Commit: cb243c7 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.08

@betulependule
betulependule force-pushed the osh/identifier-support branch from cb243c7 to 7124743 Compare August 26, 2026 11:44
@betulependule betulependule moved this from New to In review in Packit pull requests Aug 26, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

🤖 Review · ❌ Terminated · Started 11:45 AM UTC · Ended 11:56 AM UTC

Commit: 7124743 · View workflow run →

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review fullsend-ai-review Bot added area/openscanhub Related to the OpenScanHub integration area/copr Related to the Copr integration kind/documentation Improvements to docs labels Aug 26, 2026
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:45 AM UTC · Completed 11:56 AM UTC

Commit: 7124743 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.36

@TomasTomecek

TomasTomecek commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

/fs-review

edit: I was really just checking if fullsend works: it doesn't and am working on fixing it

https://github.com/packit/packit.dev/actions/runs/39770061438/job/119795111014

@betulependule

Copy link
Copy Markdown
Contributor Author

While the option is technically supported, there were some issues with necessary configuration not being passed to OSH, making this support not exactly functional in the current state.

The original issue for more context: packit/packit#2763

Closing this for now. Can be reopened once support actually works properly.

@github-project-automation github-project-automation Bot moved this from In review to Done in Packit pull requests Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/copr Related to the Copr integration area/openscanhub Related to the OpenScanHub integration kind/documentation Improvements to docs ready-for-merge All reviewers approved — ready to merge

Projects

Development

Successfully merging this pull request may close these issues.

4 participants