Skip to content

fix(downloader): remove the partial file of a failed download #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 1 commit into from
Oct 12, 2026
Merged

fix(downloader): remove the partial file of a failed download #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions src/Module/Downloader/Downloader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,26 +507,30 @@ private function processAsset(DownloadContext $context): \Closure

$this->logger->info('Downloading into %s', (string) $temp);

await(coroutine(
(static function () use ($context, $file): void {
$generator = $context->asset->download(
// static fn(int $dlNow, int $dlSize, array $info): mixed => ($context->onProgress)(
// new Progress(
// total: $dlSize,
// current: $dlNow,
// message: 'downloading...',
// ),
// ),
);

foreach ($generator as $chunk) {
$file->fwrite($chunk);
}
}),
)->then(null, static function (\Throwable $e) use ($file): void {
@\unlink($file->getPath());
try {
await(coroutine(
(static function () use ($context, $file): void {
$generator = $context->asset->download(
// static fn(int $dlNow, int $dlSize, array $info): mixed => ($context->onProgress)(
// new Progress(
// total: $dlSize,
// current: $dlNow,
// message: 'downloading...',
// ),
// ),
);

foreach ($generator as $chunk) {
$file->fwrite($chunk);
}
}),
));
} catch (\Throwable $e) {
// Released before the delete: on Windows a file deleted while open can keep its name until the handle closes
$file = null;
@\unlink((string) $temp);
throw $e;
}));
}

return $context->file = $file;
};
Expand Down
17 changes: 17 additions & 0 deletions tests/Unit/Module/Downloader/DownloaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,23 @@ public function releaseFailingForOtherReasonsIsNotForgotten(): void
}
}

#[Test]
public function failedDownloadLeavesNoFileInTheTempDirectory(): void
{
$repository = self::repoWithReleases(
[
'v3.4.0' => ['roadrunner-3.4.0-linux-amd64.tar.gz'],
'v3.2.0' => ['roadrunner-3.2.0-linux-amd64.tar.gz'],
],
['roadrunner-3.4.0-linux-amd64.tar.gz' => new \RuntimeException('Connection reset by peer')],
);

$result = $this->run([$repository], self::software());

Assert::same($result->version->string, 'v3.2.0');
Assert::false(\file_exists($this->tempDir . '/roadrunner-3.4.0-linux-amd64.tar.gz'));
}

#[DataProvider('provideGradualStrategies')]
#[Test]
public function gradualFilteringSelectsAssetByEachStrategy(?OperatingSystem $os, ?Architecture $arch): void
Expand Down
Loading