Repository navigation
ci: run cs-fix on the minimum supported PHP - #12
Merged
Merged
Conversation
spiral/gh-actions#14 defaults the reusable cs-fix workflow to PHP 8.2 and stops ignoring the PHP platform requirement, so each caller passes its own minimum PHP. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
phpofcs-fix.ymlto 8.2 and installs the root with--ignore-platform-req='ext-*'instead of--ignore-platform-reqs, so the PHP version is now checked. Each caller passes its own minimum PHP explicitly.require.phpis>=8.1and the root with dev dependencies installs on it (internal/dloadresolves to 1.14, the last release for 8.1).spiral/code-styleresolves to 2.3.x: 2.4 needs PHP 8.2, so its import ordering rules are not applied here.Checklist
php-cs-fixer fix --dry-runon PHP 8.1 locally