Repository navigation
Allow gitlib 2 - #1235
Draft
lyrixx wants to merge 2 commits into
Draft
Allow gitlib 2#1235lyrixx wants to merge 2 commits into
lyrixx wants to merge 2 commits into
Conversation
gitlib 2 requires PHP 8.4: grumphp requires ^1.7.1 || ^2.0, and gets 1.7.1, which has the security fixes of 2.0, on PHP 8.2 and 8.3. Since 1.7, the same code runs with both versions. - The changed files are named by File::getName(), the new name of a renamed file with both versions: getNewName() is nullable in gitlib 2. - The specs no longer double the classes of gitlib, which are final in gitlib 2: they run on temporary git repositories instead. - The raw diff of the specs had spaces instead of a tab, and the status of a modification for a new file: gitlib 2 refuses it.
To drop once gitlib 2.0 is released: the highest dependencies on PHP 8.4 and 8.5 then install it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitlib 2.0 requires PHP 8.4: grumphp requires
^1.7.1 || ^2.0, and keeps 1.7.1, which has thesecurity fixes of 2.0, on PHP 8.2 and 8.3. Since #1237, the same code runs with both.
The specs no longer double the classes of gitlib, final in 2.0: they run on temporary git
repositories. The raw diff fixture had spaces instead of a tab, which 2.0 refuses.
File::getName()is the new name of a renamed file with both versions, wheregetNewName()isnullable in 2.0.
The
[DO NOT MERGE]commit installs the main branch of gitlib as 2.0.0 on thehighestjobs onPHP 8.4 and 8.5: drop it once 2.0 is released.