Repository navigation
Conversation
lyrixx
marked this pull request as ready for review
November 7, 2026 22:38
veewee
reviewed
Nov 11, 2026
| } catch (ParseException $exception) { | ||
| $exception->setParsedFile($file->getPathname()); | ||
| $errors[] = YamlLintError::fromParseException($exception); | ||
| $errors[] = YamlLintError::fromParseException($exception, $file->getPathname()); |
Contributor
There was a problem hiding this comment.
Line 67 always sets the parsed file name, so in theory it could be null, but it will never be null.
Not sure it's worth breaking the YamlLintError contract for that purpose.
10 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YamlLintError::fromParseException()takes the file name, likePhpParserError::fromParseException()symfony/yaml throws a
ParseExceptionwithout snippet for some errors, like a file that isn'tUTF-8. Its recent versions (6.4.50, 7.4.23, 8.1.11) return
nullfromgetSnippet()andgetParsedFile()(symfony/symfony@54bbbdf1), wheregetSnippet()threw aTypeErrorbefore:the constructor of
YamlLintErrorthrows it now. The nullable getters also make Psalm fail on thehighestandlowestjobs.The lock gets symfony/yaml 7.4.23, so that the new test runs on the
lockjobs too. It also fixesCVE-2026-109413.