Repository navigation
Update phpstan/tally to ^1.0.1 - #7072
Merged
Merged
Conversation
ExpectationSource::rewrite() is replaced by edits(), which returns the CodeEdit of the header comment instead of the rewritten file. Amp-Thread-ID: https://ampcode.com/threads/T-01a1dc2a-acc9-71d3-bf5f-24be38444155
1.0.1 requires ext-posix only for its own development, so phpstan-src installs on Windows again. Amp-Thread-ID: https://ampcode.com/threads/T-01a1dc31-07ff-7750-b3ea-2915ebc9d89a
ondrejmirtes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
phpstan/tallyfromdev-release/1.xto the tagged 1.0.1 release.Tally 1.0.0 replaces
ExpectationSource::rewrite(): stringwithedits(): list<CodeEdit>, soAnalysedFileHeader::write()now returns the edit of the header comment at the top of eachtests/bench/datafile instead of the rewritten code. Without this, everyvendor/bin/tallycommand fails with a fatal error.1.0.0 required
ext-posix, which broke installing phpstan-src on Windows; 1.0.1 requires it only for its own development. The Benchmarks workflow loads it, whichtally runstill needs.Checked locally:
tally runpasses on a microbenchmark and onbug-13933.php, and for a copy of that file without its header comment, both the printed patch andtally acceptwrite the header correctly.