Repository navigation
Fix "Undefined array key" error for stream resources without URI - #228
Merged
Merged
Conversation
vjik
commented
Oct 27, 2026
Member
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow URI guards preserve existing behavior, and regression tests cover filename detection and both upload transports.
No open issues 🎉
What changed in this PR
Fixes undefined-array-key errors when uploading stream resources whose metadata has no URI, while preserving existing handling of file paths and URI-backed streams.
Changes:
- Guard missing URI metadata in filename detection and cURL upload handling.
- Add socket-based regression tests for
InputFileand both upload transports. - Document the bug fix in the changelog.
| File | Description |
|---|---|
tests/Type/InputFileTest.php |
Tests filename and extension detection for streams without a URI. |
tests/Transport/NativeTransport/NativeTransportTest.php |
Tests native uploads using streams without a URI. |
tests/Transport/CurlTransport/CurlTransportTest.php |
Tests the string-file upload fallback for streams without a URI. |
tests/Support/TestHelper.php |
Adds a shared socket-pair helper for regression tests. |
src/Type/InputFile.php |
Returns no inferred filename when URI metadata is absent. |
src/Transport/CurlTransport.php |
Guards URI access before selecting file-based uploads. |
CHANGELOG.md |
Records the stream metadata bug fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.