Repository navigation
Patch FES Translation in cases where localStorage is not available - #9324
Merged
Merged
Conversation
limzykenneth
force-pushed
the
modular-fes
branch
from
October 24, 2026 11:53
01d2dc3 to
31e196b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9323
Changes:
Guard use of
localStorageAPI behind a feature detection check that should catch most if not all cases where the API would not be available.Also adds p5.js version to local storage key.
PR Checklist
npm run lintpasses