Repository navigation
Trending: public /trending on a real source, and the promo actually granted - #429
Merged
Merged
Conversation
…lly granted Trending targeting was doing nothing: SameBrain returns no topics and nothing ran the pull, so the list had been stale since September and no ad was boosted. - Pull from RSSAmp's public /api/trending, with no secret. - Add /trending, showing subjects as written (label) rather than the stemmed match key, with an honest note when the list is out of date. - Grant the 90-day promo with the service client: ad_promos has no insert policy, so under the user's session it failed silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan50 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 30 | LOW: 18
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trending targeting was doing nothing. SameBrain returns no topics, nothing ran the pull, and the list had been stale since 2026-09-12, so no ad was boosted. The dashboard promo also failed silently, because
ad_promoshas no insert policy./api/trending(Trending: daily term rollup and a public /api/trending rssamplifier.com#271). No secret./trending, in the sitemap and linked from the ad form. It shows subjects as written, via a newlabelcolumn, and says so when the list is out of date.The
labelmigration is already applied on prod. An hourly crontab line on dev2 runs the pull.🤖 Generated with Claude Code