Repository navigation
Wrap multiline prompt text above the input - #2164
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A prompt with a newline puts the text above the input in a separate window. That window does not inherit
wrap_lines, so long prompt lines are cut off even when wrapping is enabled.Change
Use the session's
wrap_linesfilter for the prompt window above the input as well. The filter stays dynamic, andwrap_lines=Falsestill clips the line.The regression tests render a
PromptSessionin a narrow terminal. They cover a long prompt line, several long lines, short lines, an exact-width line wrapping disabled and changing a wrap filter between prompts.Fixes #2010.
Tests
tests/test_shortcuts.py.ruff check .andruff format --check .: passed.mypy --strict src/for Linux, Windows and macOS: passed.typos .: passed.These checks ran locally on Linux with Python 3.14.10. A separate VT100 output capture also shows the long prompt wrapping instead of being cut off.