Repository navigation
Fix indentation in ConditionalKeyBindings documentation example - #2168
Open
Doomguy-BFG9000 wants to merge 1 commit into
Open
Doomguy-BFG9000 wants to merge 1 commit into
Doomguy-BFG9000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the extra indentation in the
ConditionalKeyBindingsdocumentation example so thebindingsassignment is at module scope, alongside the function definition. Copying the existing snippet raisesIndentationError.Fixes #1938.
Validation: the exact documented snippet fails to compile before the change, then compiles and executes with the documented imports and an existing key-binding collection after it. The Sphinx HTML build succeeds before and after with the same three existing Windows autodoc warnings. The rendered example was inspected at 1400px and 800px widths.
The unmodified Windows test suite has four failures (147 passed, 5 skipped); this PR changes only the example indentation.