Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a one-row
TextAreawithwrap_lines=Truefills its width exactly, the cursor can jump to the terminal's top-left corner. For example, with a 20-column input and a>>>prompt, typingabcdefghijklmnoptriggers it. Typing another character restores the cursor, and moving left back to the boundary triggers it again.Include the character under the cursor when calculating the scroll height. The height helper's slicing behavior and prefix-width guards stay intact.
Refs #2071 and follows up on the exact-boundary case in #2084, whose author invited others to take it over. I reproduced this boundary jump, but not the accumulating horizontal drift in #2071.
Verified with real macOS PTY input and VT100 output, plus regression tests for prompts, continuation prefixes, wide characters, and one- and two-row windows. The full test suite and configured checks pass on Python 3.14. Hermes, Linux/SSH and WSL were not tested.
Prepared with AI assistance.