Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/prompt_toolkit/contrib/telnet/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ def __init__(self, connection: socket.socket, encoding: str) -> None:

def write(self, data: str) -> None:
data = data.replace("\n", "\r\n")
self._buffer.append(data.encode(self._encoding, errors=self._errors))
# A literal 0xFF byte has to be sent as IAC IAC, otherwise the client
# interprets it (and the bytes after it) as a telnet command.
encoded = data.encode(self._encoding, errors=self._errors)
self._buffer.append(encoded.replace(IAC, IAC + IAC))
self.flush()

def isatty(self) -> bool:
Expand Down
29 changes: 29 additions & 0 deletions tests/test_telnet.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
from __future__ import annotations

import socket

from prompt_toolkit.contrib.telnet.protocol import TelnetProtocolParser
from prompt_toolkit.contrib.telnet.server import _ConnectionStdout


def test_connection_stdout_escapes_iac():
a, b = socket.socketpair()
try:
stdout = _ConnectionStdout(a, encoding="latin-1")
# "\xff\xfc\x01" is IAC WONT ECHO when sent unescaped.
stdout.write("a\xff\xfc\x01b\n")
wire = b.recv(1024)
finally:
a.close()
b.close()

assert wire == b"a\xff\xff\xfc\x01b\r\n"

data: list[bytes] = []
commands: list[tuple[bytes, bytes]] = []
parser = TelnetProtocolParser(data.append, lambda rows, columns: None, print)
parser.command_received = lambda command, d: commands.append((command, d))
parser.feed(wire)

assert b"".join(data) == "a\xff\xfc\x01b\r\n".encode("latin-1")
assert commands == []
Loading