Repository navigation
Conversation
…trusted keys on customer SLES nodes Co-Authored-By: Claude <noreply@anthropic.com>
imaqsood
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
October 29, 2026 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the SLES-only
execinapache::mod::phpthat ranzypper ar ... --gpg-auto-import-keysandzypper refreshto add an EOL openSUSE Leap repo, along with therequireon it. Keep the SLESapache::modbranch, which needs themod_${mod}.solib path. The acceptance harness (spec/setup_acceptance_node.pp) already adds the fallback repo before the suite runs, so CI keeps its package source. Add a Suse unit spec checking that the class has no zypper exec.Jira: https://perforce.atlassian.net/browse/MODULES-12075
Approach
A module should never change a customer's package sources, and the old exec auto-trusted GPG keys from an EOL repo. The repo was only there for unregistered GCP BYOS CI images, and
spec/setup_acceptance_node.ppalready sets it up through an exec run before the suite. That keeps acceptance working while removing the side effect from the shipped code. The patch release is a release-pipeline step; per the repo rules, the patch does not touchmetadata.jsonor the CHANGELOG.Acceptance criteria
Local checks
cat-module(static, unit; full suite): pass, 15706 passed, 0 failed🤖 Generated with Claude Code