Repository navigation
Fix halogen:dev script - #1432
Merged
Merged
Conversation
Fixes 1427. Explanation of changes: - `--outfile` path is relative to the package directory (`docs-search/client-halogen`) and so `./../../generated-docs` resolves to `./generated-docs` (where `spago docs` outputs to). So this is assuming that the `halogen:dev` is intended to be used with generated docs for `spago` itself (and its dependencies). - `esbuild`'s serve mode (`--servedir`) does not read from stdin, which is where `spago --bundle` writes to, and serve mode doesn't seem to be necessary anyways because the HTML can be opened over `file://` protocol.
thomashoneyman
approved these changes
Oct 22, 2026
thomashoneyman
left a comment
thomashoneyman
left a comment
Member
There was a problem hiding this comment.
Checked it out, works! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1427.
Explanation of changes:
--outfilepath is relative to the package directory (docs-search/client-halogen) and so./../../generated-docsresolves to./generated-docs(wherespago docsoutputs to). So this is assuming that thehalogen:devis intended to be used with generated docs forspagoitself.esbuild's serve mode (--servedir) does not read from stdin, which is wherespago --bundlewrites to, and serve mode doesn't seem to be necessary anyways because the HTML can be opened overfile://protocol.Checklist:
READMEAI Disclosure
Did this by hand but used Opus 5.5 for research and review.
Demo
Running through the instructions in a clean checkout of the repo, in
nix developshell. (Fast forwarded through compiler output, I getFailed to call 'purs graph'error when runningspago bundle -p spago-bin, but that seems unrelated?)CleanShot.2026-10-22.at.12.48.47.AM-converted.mp4