Skip to content

[Maint] Add .git-blame-ignore-revs - #2933

Open
echedey-ls wants to merge 5 commits into
pvlib:mainfrom
echedey-ls:dev/exclude-commits-from-blame
Open

echedey-ls wants to merge 5 commits into
pvlib:mainfrom
echedey-ls:dev/exclude-commits-from-blame

Conversation

@echedey-ls

@echedey-ls echedey-ls commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Addresses various comments in #2642, adds #2805 commit (3e903d3) from issue #2802.

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license No ai
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I think it would be worth to add the configuration instruction to the Contributing guidelines. But I'm unsure were to put it. Feel free to suggest a place.

https://pvlib-python.readthedocs.io/en/stable/contributing/index.html
-> maybe add another subsection to https://pvlib-python.readthedocs.io/en/stable/contributing/how_to_contribute_new_code.html ?

@echedey-ls echedey-ls added this to the v0.16.2 milestone Nov 3, 2026

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example, compare the blame for bsrn.py:

I lean towards not documenting this. I expect we will probably not touch it very often, so mentioning it in the contributing docs might just be clutter.

@echedey-ls
echedey-ls marked this pull request as ready for review November 20, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants