Skip to content

Add wind-dependent freestanding PVsyst temperature preset - #2938

Open
sahaja9707 wants to merge 1 commit into
pvlib:mainfrom
sahaja9707:codex/2834-pvsyst-wind
Open

sahaja9707 wants to merge 1 commit into
pvlib:mainfrom
sahaja9707:codex/2834-pvsyst-wind

Conversation

@sahaja9707

Copy link
Copy Markdown

The named PVsyst temperature presets currently all have u_v=0, so selecting them does not account for wind speed. Add freestanding_wind with u_c=25.0 and u_v=1.2, the PVUSA correlation described in PVsyst's heat transfer documentation.

Document the wind measurement height and the need to match coefficients to the measurement conditions. This addresses the free-standing portion of #2834; rooftop-specific coefficients are outside this change.

Validation: all 34 tests in tests/test_temperature.py pass; Flake8 on both changed Python files and git diff --check pass. A full documentation build has not been run.

AI assistance was used to prepare this patch. The coefficients and measurement guidance were checked against the primary source above, and the implementation was tested locally.

  • Addresses add free standing and rooftop thermal coeffs for nonzero windspeed #2834 (free-standing case only; does not close the full issue)
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file, including the issue and contributor links
  • New code is fully documented, including the preset table and source reference in the existing API docstring
  • Pull request is nearly complete and ready for detailed review
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Hey @sahaja9707! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

Finally, be sure the PR description includes the PR
checklist,
and complete the items you are able to.

@sahaja9707

Copy link
Copy Markdown
Author

I've made a change to add the freestanding_wind PVsyst temperature preset using the published coefficients u_c=25.0 and u_v=1.2.

The PR also documents the wind measurement height and adds a numerical test. All 34 temperature tests and style checks pass.

This addresses the free-standing portion of #2834. Could you please review the PR and merge it if everything looks good? I’m happy to address any feedback.

@cwhanse

cwhanse commented Nov 8, 2026

Copy link
Copy Markdown
Member

@sahaja9707 you're ahead of the maintainers with this one :) We need to get consensus that pvlib should change these defaults, before reviewing this PR. Thanks for your patience.

@mikofski

mikofski commented Nov 8, 2026

Copy link
Copy Markdown
Member

I support this improvement.

@wholmgren

Copy link
Copy Markdown
Member

Finally a useful AI contribution!

I'd describe this as adding a new option that is widely used in the industry. It doesn't change default behavior and it's entirely opt-in. I suggest we merge it in a few days unless anyone objects.

Comment thread pvlib/temperature.py
Comment on lines +429 to +433
.. [3] PVsyst SA, "Heat transfer coefficients (U-values)," PVsyst
documentation. [Online]. Available:
https://www.pvsyst.com/help/project-design/array-and-system-losses/array-thermal-losses/u-value-measurement.html.
[Accessed: 8-Nov-2026].

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. [3] PVsyst SA, "Heat transfer coefficients (U-values)," PVsyst
documentation. [Online]. Available:
https://www.pvsyst.com/help/project-design/array-and-system-losses/array-thermal-losses/u-value-measurement.html.
[Accessed: 8-Nov-2026].

The new coefficients are already in [1]. I don't see the need to cite one more time the same content. You may update [1] accessed date.

@adriesse adriesse Nov 11, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new link looks like the modern version of [1]. Anyway, it seems like PVUSA needs to be referenced here also.

Comment thread pvlib/temperature.py
Comment on lines +404 to +408
The ``freestanding_wind`` parameters are the PVUSA correlation described
in [3]_ for open-rack systems with wind speed data. Standard meteorological
wind speed is measured at 10 m above ground. The wind loss coefficient
must be appropriate for the measurement height; these coefficients are
not universal. Use coefficients fitted to the installation when available.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although true, this sounds a bit misleading. One can more easily change the wind speed from the measured height to the height of interest than fit data. At least mention atmosphere.windspeed_powerlaw.

Do not state Use coefficients fitted to the installation when available.. That is true for all experimental models.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not state Use coefficients fitted to the installation when available.. That is true for all experimental models.

But it's more true for temperature models!!

@kandersolar kandersolar added this to the v0.16.2 milestone Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants