Repository navigation
Do not infer CIGS coefficients for ambiguous Thin Film modules - #2949
Closed
Solarboaters wants to merge 1 commit into
Closed
Solarboaters wants to merge 1 commit into
Solarboaters wants to merge 1 commit into
Conversation
Hey @Solarboaters! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
Member
|
This doesn't adequately inform a user what would be expected. We maintainers don't have time to fix PRs from AI agents through review comments. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map the ambiguous
Thin Filmtechnology toNoneinstead ofcigs, following the approach proposed in #1984. The spectral calculation then requires a specific technology or explicit coefficients rather than silently using the wrong coefficients. Document both workarounds.Related prior attempt: #2940 (closed unmerged). This submission adds independent regression and workaround tests.
Validation: the two ambiguous-technology cases fail before the change and pass afterward. All 557 PVSystem, ModelChain and spectrum tests pass on Python 3.12 (19 SciPy numerical warnings). The changed-line Flake8 check passes. The HTML documentation build completes with gallery execution disabled and seven warnings, including reference-target errors in
pvlib.spaand an uncacheable configuration warning; this is not a warning-free documentation build. No field-performance validation is claimed.remote-data) and Milestone are assigned to the Pull Request and linked Issue.AI-assisted implementation and testing.