Skip to content

Do not infer CIGS coefficients for ambiguous Thin Film modules - #2949

Closed
Solarboaters wants to merge 1 commit into
pvlib:mainfrom
Solarboaters:fix/ambiguous-thin-film-type
Closed

Solarboaters wants to merge 1 commit into
pvlib:mainfrom
Solarboaters:fix/ambiguous-thin-film-type

Conversation

@Solarboaters

Copy link
Copy Markdown

Map the ambiguous Thin Film technology to None instead of cigs, following the approach proposed in #1984. The spectral calculation then requires a specific technology or explicit coefficients rather than silently using the wrong coefficients. Document both workarounds.

Related prior attempt: #2940 (closed unmerged). This submission adds independent regression and workaround tests.

Validation: the two ambiguous-technology cases fail before the change and pass afterward. All 557 PVSystem, ModelChain and spectrum tests pass on Python 3.12 (19 SciPy numerical warnings). The changed-line Flake8 check passes. The HTML documentation build completes with gallery execution disabled and seven warnings, including reference-target errors in pvlib.spa and an uncacheable configuration warning; this is not a warning-free documentation build. No field-performance validation is claimed.

  • Closes First Solar CEC modules are inferred to be CIGS instead of CdTe #1984
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file, with the issue link and contributor username.
  • New code is fully documented, including docstrings where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

AI-assisted implementation and testing.

@github-actions

Copy link
Copy Markdown

Hey @Solarboaters! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

Finally, be sure the PR description includes the PR
checklist,
and complete the items you are able to.

@cwhanse

cwhanse commented Nov 18, 2026

Copy link
Copy Markdown
Member

This doesn't adequately inform a user what would be expected. We maintainers don't have time to fix PRs from AI agents through review comments. Sorry.

@cwhanse cwhanse closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First Solar CEC modules are inferred to be CIGS instead of CdTe

2 participants