Repository navigation
Document the URL default get_acis_station_data actually uses - #2950
Merged
cwhanse merged 3 commits intoNov 19, 2026
Merged
Conversation
The signature is url="https://data.rcc-acis.org/StnData", which is the station endpoint, but the docstring documented the GridData endpoint. The three sibling readers (get_acis_prism, get_acis_nrcc, get_acis_mpe) all default to GridData and document it correctly, so the entry looks copied across from them when the station reader was added.
cwhanse
approved these changes
Nov 18, 2026
cwhanse
left a comment
Member
There was a problem hiding this comment.
A useful AI contribution, thanks!
| * :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions`` | ||
| contains a single site (:issue:`2895`, :pull:`2896`) | ||
| * Document the URL default :py:func:`pvlib.iotools.get_acis_station_data` actually | ||
| uses. Its docstring named the GridData endpoint; the signature uses StnData. |
Member
There was a problem hiding this comment.
Suggested change
| uses. Its docstring named the GridData endpoint; the signature uses StnData. | |
| uses. Its docstring named the GridData endpoint; should be StnData. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_acis_station_datahasurl="https://data.rcc-acis.org/StnData"in its signature, the station endpoint, and its docstring documents the GridData endpoint instead.The three sibling readers
get_acis_prism,get_acis_nrccandget_acis_mpeall default to GridData and document it correctly, so the entry looks copied across from them when the station reader was added in #1767.Docstrings only, no behaviour change.
docs/sphinx/source/referencefor API changes.