Repository navigation
zero aead decrypt_into output buffer on tag failure - #15895
Open
jmestwa-coder wants to merge 1 commit into
Open
jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
Juerge3111
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AEAD
decrypt_intoleft unauthenticated plaintext in the caller's buffer when the tag check failed:EvpCipherAead::decrypt_intoletsEVP_CipherUpdatewrite straight intobufand only checks the tag inEVP_CipherFinalInvalidTag,bufholds the tampered plaintext forAESGCM,ChaCha20Poly1305,AESGCMSIVandAESOCB3(16+ byte inputs), and the whole forged chunk for the Cobblestone decryptors'update_intobufbefore raisingInvalidTag, matchingEVP_AEAD_CTX_openon BoringSSL/AWS-LC and Go'scrypto/cipherThe
test_decrypt_into_invalid_tagtests now assert the buffer is zeroed; the ChaCha20Poly1305, AESGCM and AESGCMSIV ones fail without the fix.