Repository navigation
fix(clients): retry a write when nothing was sent - #1681
Open
Goran Gajic (gorangajic) wants to merge 3 commits into
Open
Goran Gajic (gorangajic) wants to merge 3 commits into
Goran Gajic (gorangajic) wants to merge 3 commits into
Conversation
Goran Gajic (gorangajic)
force-pushed
the
goran/wiz-12618-retry-connect-failures
branch
from
October 21, 2026 14:36
4b74902 to
e2f616b
Compare
Goran Gajic (gorangajic)
marked this pull request as ready for review
October 21, 2026 14:54
A write whose connection never opened carried no request, so sending it again cannot repeat the action.
Goran Gajic (gorangajic)
force-pushed
the
goran/wiz-12618-retry-connect-failures
branch
from
October 22, 2026 12:44
86f3742 to
9db7e9d
Compare
Goran Gajic (gorangajic)
changed the title
Goran Gajic (gorangajic)
force-pushed
the
goran/wiz-12618-retry-connect-failures
branch
from
October 22, 2026 13:02
9db7e9d to
40326fe
Compare
Goran Gajic (gorangajic)
requested review from
Mateus Zitelli (MateusZitelli) and
Atchyut Preetham Pulavarthi (theonly1me)
October 23, 2026 15:29
Atchyut Preetham Pulavarthi (theonly1me)
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to WIZ-12618
Overview of Changes
About 3% of the
qawolf runnercommands Tester runs fail with "Could not reach the QA Wolf API", and in most of these the connection never opened. The CLI already says when nothing was sent, but it gives up after one try, so Tester spends a turn sending the command again.Now a write is sent again when nothing was sent the first time, since that cannot repeat the action. Tester only sees the error if every try fails. Writes that may have reached the server are still never retried.
Testing
bun run typecheck bun run lint bun run format:check bun run knip bun run testThe built CLI pointed at a closed port tries a
runner act3 times, then ends with "Nothing was sent, so this request did not take effect."Checklist