Skip to content

Reuse MINA initiator connectors after disconnects - #1355

Draft
chrjohn with Copilot wants to merge 5 commits into
masterfrom
copilot/fix-issue-1354
Draft

chrjohn with Copilot wants to merge 5 commits into
masterfrom
copilot/fix-issue-1354

Conversation

Copilot AI commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Initiator disconnects recreated the MINA IoConnector, selector, and processor pool before every reconnect. Long-lived logon failures therefore caused avoidable thread and allocation churn.

  • Reconnect lifecycle

    • Retain the existing IoConnector after normal session closure.
    • Let the existing reconnect loop call connect() on that connector.
  • Remove reset signaling

    • Remove the per-session reset attribute and connector replacement path.
    • Keep normal closeOnFlush() behavior for responder disconnects.
public void disconnect() {
    ioSession.closeOnFlush();
}

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot AI changed the title Reuse initiator connectors after disconnects Reuse MINA initiator connectors after disconnects Oct 21, 2026
Copilot AI requested a review from chrjohn October 21, 2026 15:10
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.81%. Comparing base (e6aa539) to head (df57218).

Files with missing lines Patch % Lines
...va/quickfix/mina/initiator/IoSessionInitiator.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1355   +/-   ##
=========================================
  Coverage     70.81%   70.81%           
+ Complexity     2272     2271    -1     
=========================================
  Files           161      161           
  Lines          9077     9078    +1     
  Branches       1192     1193    +1     
=========================================
+ Hits           6428     6429    +1     
  Misses         2197     2197           
  Partials        452      452           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Comment thread quickfixj-core/src/test/java/quickfix/SocketInitiatorTest.java Outdated
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disconnects (not just real reconnects) rebuild the whole IoConnector and its thread pool in SocketInitiator

2 participants