Repository navigation
Use FieldException instead of InvalidMessage for bad repeating group count - #1362
Open
philipwhiuk wants to merge 1 commit into
Open
philipwhiuk wants to merge 1 commit into
philipwhiuk wants to merge 1 commit into
Conversation
chrjohn
changed the title
FieldException instead of InvalidMessage for bad repeating group count
Member
|
@philipwhiuk thanks for the PR. Seems unit tests need adapting since now a Reject is sent instead of considering the message as garbled... |
Johnny-Kao
reviewed
Oct 29, 2026
Contributor
There was a problem hiding this comment.
@philipwhiuk philipwhiuk
Thanks for the fix! I had a quick look at the CI failures.
The two failing tests seem to just need updated expectations for the new Reject behavior.
I also noticed that testRepeatingGroupCountWithNonIntegerValues might now pass without actually checking anything, since the exception is stored rather than thrown.
Might be worth checking the reject reason/tag there, and confirming the behavior with RejectInvalidMessage=N as well.
Hope this helps!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change from InvalidMessage to FieldException
Fixes #1360