Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
robhogan
marked this pull request as ready for review
October 23, 2026 19:48
… build Since #2007, a re-added file the graph already holds stays in the added set as well as modified. After a failed build, deleting it cancels the addition and leaves it modified: ``` foo deleted and re-added during build N -> build N+1 revisits foo, fails foo deleted -> every build: "Failed to get the SHA-1 for: foo" ``` This moves it from added to modified instead. Changelog: Internal Test plan: - New unit test, failing without this change.
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2007, a re-added file the graph already holds stays in the added set as well as modified. After a failed build, deleting it cancels the addition and leaves it modified:
This moves it from added to modified instead.
Changelog: Internal
Test plan: