Repository navigation
Derive multiline TextInput state from props (#59218) - #59218
Closed
cipolleschi wants to merge 1 commit into
Closed
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126285220. |
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D126285220
branch
from
October 22, 2026 11:18
7c6f2f7 to
e5481d0
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 22, 2026
Summary: Use `TextInputProps::multiline` as the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props. Changelog: [Internal] Differential Revision: D126285220
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 22, 2026
Summary: Pull Request resolved: react#59218 Use `TextInputProps::multiline` as the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props. Changelog: [Internal] Differential Revision: D126285220
cipolleschi
force-pushed
the
export-D126285220
branch
from
October 22, 2026 11:21
e5481d0 to
cd0c89f
Compare
Summary: Use `TextInputProps::multiline` as the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props. Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D126285220
cipolleschi
force-pushed
the
export-D126285220
branch
from
October 23, 2026 13:36
cd0c89f to
8558b85
Compare
Visual regressionNo visual differences at android: no capture |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 83a76fa When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 83a76fa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use
TextInputProps::multilineas the source of truth for multiline checks instead of inferring it from the backed UIKit class. This keeps responder offset and selection restoration logic aligned with the declarative props.Changelog: [Internal]
Reviewed By: Abbondanzo
Differential Revision: D126285220