Skip to content

Delegate TouchableHighlight accessibility to View (#59402) - #59402

Open
javache wants to merge 4 commits into
react:mainfrom
javache:export-D127143599
Open

javache wants to merge 4 commits into
react:mainfrom
javache:export-D127143599

Conversation

@javache

@javache javache commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Let View normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2026
@meta-codesync

meta-codesync Bot commented Oct 23, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127143599.

javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
@meta-codesync meta-codesync Bot changed the title Delegate TouchableHighlight accessibility to View Delegate TouchableHighlight accessibility to View (#59402) Oct 23, 2026
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
@javache
javache force-pushed the export-D127143599 branch 2 times, most recently from b6faffa to 93fafba Compare October 23, 2026 14:50
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
)

Summary:
Pull Request resolved: react#59399

Only construct accessibility state in Pressable and Touchable wrappers when a state object, ARIA state or disabled value was supplied. Preserve explicit empty state objects, false and mixed values, and custom-child state when wrapper inputs are absent. Keep View normalisation unchanged.

Changelog:
[General][Fixed] - Avoid manufacturing empty accessibility state objects in pressable wrappers.

Differential Revision: D127141096
Summary:
Pull Request resolved: react#59398

Mock only the native View boundary so Jest exercises the real `View` prop normalisation. Preserve native ref methods and migrate dependent tests to observe native host state rather than implementation details.

Changelog: [Internal]

Differential Revision: D127141935
Summary:
Forward accessibility props to `View` rather than building duplicate accessibility state and value objects. Preserve explicit disabled precedence and existing press behaviour.

Changelog:
[General][Fixed] - Avoid synthesising empty accessibility props in Pressable.

Differential Revision: D127143129
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599
javache added a commit to javache/react-native that referenced this pull request Oct 23, 2026
Summary:
Pull Request resolved: react#59402

Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling.

Changelog:
[General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight.

Differential Revision: D127143599

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant