Repository navigation
[perf] Remove usage of CloningVisitor on AstResolver - #8861
Merged
Merged
Conversation
samsonasik
force-pushed
the
remove-cloning-ast
branch
from
November 12, 2026 18:03
f878111 to
1137835
Compare
samsonasik
marked this pull request as ready for review
November 12, 2026 18:04
Member
Author
|
Re-open, this should be green now 👍 |
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Fewer nodes to worry about, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AstResolverdon't need changed node reprinting, soCloningVisitoris not needed. It was usingNodeScopeAndMetadataDecoratorwhich utilizeCloningVisitoron final node result get.This PR eliminate
CloningVisitoronAstResolver.Bench (
bench/ast_resolver_no_cloning_bench.php):$parsedFileNodes