[kix]

CommandConfigureToAttributeRector moves setName(), setDescription(), setAliases() and setHidden() out of configure() into #[AsCommand(...)]. It never checks that a name ends up in the attribute.

AsCommand::__construct() takes a required string $name as its first argument. When a command gets its name from somewhere else, for example the constructor:

final class SomeCommand extends Command
{
    public function __construct(?string $name = 'app:some')
    {
        parent::__construct($name);
    }

    protected function configure(): void
    {
        $this->setDescription('Some description');
    }
}

the rule currently produces #[AsCommand(description: 'Some description')]. Compiling the container (or booting the console) then fails with:

ArgumentCountError: Symfony\Component\Console\Attribute\AsCommand::__construct(): Argument #1 ($name) not passed

We hit this running the Symfony 6.0-7.2 sets on a Symfony 7.4 app: two commands got a nameless attribute and every bin/console call crashed.

Change

Before extracting anything, require that a name will be there: either already on an existing #[AsCommand] (name:) or set by a constant setName() in configure(). If there is something to move into the attribute but no name, the class is left untouched (same approach as the existing skip for non-constant values). configure() bodies with nothing to move, like empty_configure_body, still behave as before.

Tests

New fixtures:

• skip_name_passed_to_parent_constructor: the case above, left unchanged. Fails without the change.
• skip_non_constant_name: setName($this->commandName) next to a constant description, left unchanged. Fails without the change.
• description_with_name_on_existing_attribute: #[AsCommand(name: ...)] plus a description in configure() still converts (regression guard).

The rule's tests pass (17), plus ECS and PHPStan.

🤖 Generated with Claude Code

[samsonasik]

early check :

if ($node->isFirstClassCallable()) {
    return null;
}

here ...

[bbrala]

We hit the same bug running the composer-based Symfony set (withComposerBased(symfony: true), Rector 2.8.4, Symfony 8.2.0-BETA1) on Drupal core.

Drupal\Core\Command\ServerCommand passes its name to parent::__construct('server') and only calls setDescription() in configure(). The rule turned that into #[AsCommand(description: 'Starts up a webserver for a site.')], and every core/scripts/drupal call then fails with:

ArgumentCountError: Symfony\Component\Console\Attribute\AsCommand::__construct(): Argument #1 ($name) not passed

The other 11 commands in core set their name with setName() and convert fine.

Commit with the change: https://git.drupalcode.org/issue/drupal-3638148/-/commit/0283aebd5ce13193397e2c300eb07786caf91187
CI: https://git.drupalcode.org/project/drupal/-/merge_requests/17813 (all Build tests fail on this)

I ported the check from this PR onto the rule bundled in Rector 2.8.4 and re-ran it on core: ServerCommand is now skipped, and DbDumpCommand (which uses setName()) still converts to #[AsCommand(name: 'dump-database-d8-mysql', description: '...')]. So this fixes it for us. Would be great to get it in.

[TomasVotruba]

I'll look into it...

[TomasVotruba]

Thank you 👍

[TomasVotruba]

I'll make new release today 🤞