Activity

1. Brainshaker95

   added

   bug

   on Aug 31, 2026
2. TomasVotruba commented on Aug 31, 2026

   

   TomasVotruba

   on Aug 31, 2026

   Member

   More actions

   Thank you for your report!

   We'll need an isolated failing demo link from: http://getrector.com/demo,
   that way we can reproduce the bug.
3. Brainshaker95 commented on Aug 31, 2026

   

   Brainshaker95

   on Aug 31, 2026

   Author

   More actions

   The demo can't show this one. The rule bails out before it gets anywhere near the broken part:

   https://github.com/rectorphp/rector-phpunit/blob/c4e571ee6d61aa0bf68346bab12b85e2df3aead2/rules/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector.php#L96-L99

   matchExistingClassName() goes through ReflectionProvider::hasClass(), so the test class has to be autoloadable. The demo runs one snippet with no autoloader, so there is no FooTest to find and it returns null every time. Any demo link is going to say "no change" no matter what I put in it.

   Smallest thing I could get it to fail on — four files, 2.6.5:

   composer.json

   {
       "name": "acme/see-repro",
       "autoload": {
           "psr-4": {
               "App\\": "src/"
           }
       }
   }

   rector.php

   <?php
   
   declare(strict_types=1);
   
   use Rector\Config\RectorConfig;
   
   return RectorConfig::configure()
       ->withPaths([__DIR__ . '/src'])
       ->withPreparedSets(rectorPreset: true);

   src/Tests/FooTest.php

   <?php
   
   declare(strict_types=1);
   
   namespace App\Tests;
   
   final class FooTest {}

   src/Foo.php

   <?php
   
   declare(strict_types=1);
   
   namespace App;
   
   use App\Tests\FooTest;
   
   /**
    * @see FooTest
    */
   final class Foo {}

   composer dump-autoload && vendor/bin/rector process --dry-run gives:

    /**
     * @see FooTest
   + * @see \App\Tests\FooTest
     */
    final class Foo {}

   The tag is already there, just imported. hasAlreadySeeAnnotation() compares the raw docblock text to '\\' . $testCaseClassName, so FooTest never equals \App\Tests\FooTest and it adds a second one.

   The fallback in shouldSkipClass() misses it too, since hasClass('FooTest') is false for the short name.

   I suspect that's what happened in #9795 as well — if the test class isn't autoloadable under one of the names the resolver generates, the rule quietly does nothing and looks fixed.

   Worth noting it compounds: php-cs-fixer's fully_qualified_strict_types imports @see targets by default, so on a project running both, every run leaves one more tag behind.
4. samsonasik commented on Sep 1, 2026

   

   samsonasik

   on Sep 1, 2026

   Member

   More actions

   Reproduced at https://getrector.com/demo/6e45b252-53d3-4331-9904-7f684490d544

   👍React with 👍1Reacted by Tomas Votruba
5. samsonasik commented on Sep 1, 2026

   

   samsonasik

   on Sep 1, 2026

   Member

   More actions

   I created PR:

   • [CodeQuality] Skip existing imported or short @ see annotation in AddSeeTestAnnotationRector rector-phpunit#779

   for it.
6. TomasVotruba

   closed this as completedin rector-phpunit#779on Sep 1, 2026
7. Brainshaker95 commented on Sep 1, 2026

   

   Brainshaker95

   on Sep 1, 2026

   Author

   More actions

   Sorry, i don't know what I did wrong, since it wasn't able to reproduce it in the dmeo myself. Thanks @samsonasik for helping out and providing the fix!
8. samsonasik commented on Sep 1, 2026

   

   samsonasik

   on Sep 1, 2026

   Member

   More actions

   @Brainshaker95 that's fine. Please try latest "rector/rector": "dev-main" in case there is still issue with it.