Repository navigation
Browser tests in CI, a sharper favicon, a centred hero - #339
Merged
Merged
Conversation
The old icon was a thin Cinzel TA on cream, upscaled from a small image: the hairlines vanished at 16px and the cream blended into light tabs. favicon.svg is drawn from Cinzel Decorative Black outlines; favicon.ico (16, 32, 48) and apple-touch-icon.png are rendered from it. The unused icon-512.png and the redundant favicon-32x32.png are removed.
The Azure AI & Data Fundamentals badge stands for two certifications, so the figure was written by hand as 11 next to 10 badges. It is now the sum of the list, with count: 2 on the shared badge, and cannot drift.
Playwright 1.64.1 against astro preview: every section renders without console errors, every image loads, internal anchors exist, external links are https, the CV and icons are served, no overflow and equal gutters at 320, 390, 768 and 1280px, the four themes from a fixed clock, the navigation's reveal, and the page without JavaScript or with reduced motion. CI runs them before Lighthouse.
Below 920px the hero stacks, but its text stayed left-aligned above a centred photo: off-balance on tablets and narrow windows. The text is now centred, with balanced lines; on phones the credentials take their own line instead of leaving the bar at the end of one. The company logos wrap in full rows of three, then two, instead of leaving one alone. Tests check both, and fail on the previous layout.
rememberYou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests
Playwright (1.64.1, exact pin) against the built site, run in CI between the build and Lighthouse. 15 tests, about 4 s:
theme-color;Since Dependabot merges and deploys on green CI, these now also guard what goes live.
Favicon
A bold TA monogram (Cinzel Decorative Black) in cream on a terracotta rounded tile, as SVG, with
favicon.ico(16/32/48) andapple-touch-icon.pngrendered from it. Readable at 16px, on light and dark tabs.Figures
The certification figure is now counted from the list. The Azure AI & Data Fundamentals badge counts as two, so it stays 11.
Hero and logos
Below 920px the hero stacks, but its text stayed left-aligned above a centred photo, off-balance on tablets and narrow windows. The text is now centred with balanced lines, and on phones the credentials take their own line. The company logos wrap in full rows (3 + 3, then 2 + 2 + 2) instead of leaving one alone. Both are tested; the tests fail on the previous layout.