Repository navigation
Self-updating: Lighthouse 13 in the tests, majors apart, Node LTS - #340
Merged
Merged
Conversation
@lhci/cli has had no release since June 2025. It pins Lighthouse 12.6.1 and brings old tmp, uuid and extract-zip that Dependabot cannot update: five open security alerts, and failing security update jobs. Lighthouse 13.5.0 now runs from Playwright, alone after the other tests, with the same budgets; the median of three runs for performance. npm audit: 0.
Minor and patch updates stay grouped; each major gets its own pull request, so one that breaks never holds back the rest. The TypeScript major exception goes: that update merges by itself once it passes. A Dependabot pull request that fails CI gets a comment that notifies the owner. node-lts.yml moves .nvmrc to the newest Node LTS, 14 days after it became LTS, once CI passes on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's security update jobs were failing:
@lhci/cli(no release since June 2025) pins Lighthouse 12.6.1 and oldtmp,uuidandextract-zipthat Dependabot cannot update. Five open alerts, all in CI tooling, none in what visitors download.Changes
@lhci/cliandlighthouserc.jsonare removed.npm audit: 0 vulnerabilities.node-lts.yml): Dependabot does not update.nvmrc. Monthly, if a newer LTS has been LTS for 14 days, it runs CI on it (ci.ymlis now also callable) and, only if CI passes, commits.nvmrcto master, deploys, and syncs develop. Node 26 became LTS on 28 October, so expected on 1 December.Verified
19 tests pass locally (22 s), Lighthouse included. The Lighthouse test fails when a budget is broken.