Repository navigation
fix(workspace): a Go route inside a string literal is not an HTTP provider - #4576
Open
florianaltendorfer wants to merge 1 commit into
Open
florianaltendorfer wants to merge 1 commit into
florianaltendorfer wants to merge 1 commit into
Conversation
florianaltendorfer
requested review from
RaghavChamadiya and
swati510
as code owners
October 23, 2026 23:34
florianaltendorfer
force-pushed
the
bounty-4563
branch
4 times, most recently
from
October 27, 2026 05:55
659cc5a to
c502149
Compare
florianaltendorfer
force-pushed
the
bounty-4563
branch
from
October 27, 2026 07:38
c502149 to
e34e592
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4563.
Summary
ScanContextgainsin_string(offset), read off a second memoized mask that also blanks string bodies (mask_comments_and_strings(..., strings=True), which already understands Go raw strings).GoDialect.extractdrops a route whose match starts in a string, so a test that writes another program'smain.goin a backtick literal no longer reports that program's routes as the repo's providers.r.GET("/x", h)still matches even though its path is a string. Other dialects are unchanged, and test files are still scanned for providers.Related Issues
Closes #4563
Test Plan
pytest): newtest_go_routes_in_a_raw_string_fixture_are_not_providersintests/unit/workspace/test_contracts.py(fails onmain), plustests/unit/workspaceandtests/unit/ingestionruff check .)Checklist