[urda]

Both options were routed through parameter-with-boolean-values-plus-ask, which
only recognizes yes | no | ask and marks every other value
invalid.illegal.sshd_config. Per man ssh_config, ControlMaster also accepts
auto and autoask, and StrictHostKeyChecking also accepts accept-new and
off.

Changes

One commit per option; each moves the option out of the shared rule into its own
context, following the existing parameter-<option> naming pattern:

• ControlMaster now accepts yes | no | ask | auto | autoask. Completions
  updated via src/options.yaml and regenerated with src/build.py.
• StrictHostKeyChecking now accepts yes | no | ask | accept-new | off.
  off is scoped as a boolean false alongside no, matching the man page ("If
  this flag is set to no or off ..."). No completions change needed: they
  already listed both values, so autocomplete no longer inserts values the
  highlighter flags.
• UpdateHostKeys and VerifyHostKeyDNS keep the shared rule unchanged.
• Both rules keep the unscoped consume-while-typing matches and the
  invalid.illegal catch-all, so typos are still flagged.

Testing

• New assertions in test/syntax_test_client.ssh_config cover the four newly
  accepted values, a mid-typing partial, and an invalid value per option.
• Full suite run locally with the syntax_tests binary (build 4200): all test
  files pass, before and after each commit.

Before / After

Stock package:

With this fix:

---

• Fixes ControlMaster: auto and autoask flagged as invalid #40
• Fixes StrictHostKeyChecking: accept-new and off flagged as invalid #41

[michaelblyons]

Thanks for flagging, although I may just demote those options to the generic handling.

[urda]

Thanks for flagging, although I may just demote those options to the generic handling.

Gonna be real this is my first major sublime syntax update so I was just trying to "fit in", happy to accept any review comments + directions.

[michaelblyons]

No worries! It's possible to fully allowlist all permitted values, but (as you've noticed) that can fall out of date.

The invalid flagging was meant to be an in-between measure to help with the boolean cases.

Feel free to submit more issues or PRs as you notice flaws!

[michaelblyons]

I yanked the ControlMaster snippet changes to a new commit in your name. In another commit, I dropped ControlMaster and the host key checking out of the strict yes/no/ask group and added some of the valid values to the generic value list.

[urda]

See also:

b73bbcf

6d85c3c