Repository navigation
[6.42] [Python] Make the regression test for #23728 work effectively - #23925
Merged
guitargeek merged 1 commit intoOct 31, 2026
Merged
guitargeek merged 1 commit into
guitargeek merged 1 commit into
Conversation
…vely The test left the destructor of the branch class uncompiled until exit, so that cling had to JIT-compile it from TROOT::EndOfProcessCleanups(). On Windows, that cleanup runs from libCore's DLL_PROCESS_DETACH, after libCling's statics have already been torn down, so compiling anything there crashes with or without the fix (the no-fix run in root-project#23850 fails identically). Pre-compile the exact destructor instead: the exit-time call is then a pure cache lookup, which is the regular exit path on Windows. The bug was in that lookup on the destroyed function-local static, so the test still fails without the fix. Write the branch through the overload taking the class name and the address. The templated Branch() that the pythonization on master calls refuses collections without a compiled CollectionProxy, which silently left the tree without the branch and the test without its purpose. Also give the child process a timeout: without the fix, ROOT's crash handler can hang instead of terminating the process. Assisted-by: claude-code:claude-fable-5-1 (cherry picked from commit 98526e5)
root-project-bot
requested review from
siliataider and
vepadulano
as code owners
October 30, 2026 19:02
Test Results 24 files 24 suites 3d 22h 18m 1s ⏱️ For more details on these failures, see this check. Results for commit 0938239. |
Contributor
|
The 1378/3818 Test #478: TMVA-DNN-Optimization-Cpu .........................................................................***Failed 2.26 sec
Testing optimization: (single precision) for Cpu
Stochastic Gradient Descent: Before Training: Mean Absolute Error = 0.933004, No of Epochs = 200, total Time(sec) 0.451571, After Training: Mean Absolute error = 4.59782e-07
Stochastic Gradient Descent with momentum: Before Training: Mean Absolute Error = 0.89011, No of Epochs = 200, total Time(sec) 0.452658, After Training: Mean Absolute error = 1.2619e-07
Adam Optimizer: Before Training: Mean Absolute Error = 1.07146, No of Epochs = 200, total Time(sec) 0.495319, After Training: Mean Absolute error = 3.18713e-07
Adagrad Optimizer: Before Training: Mean Absolute Error = 0.970562, No of Epochs = 200, total Time(sec) 0.496145, After Training: Mean Absolute error = 1.51285e-07
RMSProp Optimizer without momentum: Before Training: Mean Absolute Error = 1.02591, No of Epochs = 121, total Time(sec) 0.316793, After Training: Mean Absolute error = 0.104495
----> Error: RMSPROP test failed !
CMake Error at /github/home/ROOT-CI/src/cmake/modules/RootTestDriver.cmake:265 (message):
error code: 1 |
guitargeek
merged commit Oct 31, 2026
9ef3ec2
into
root-project:v6-42-00-patches
40 of 44 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23894, requested by @guitargeek.