Repository navigation
[6.42] [tutorials] Drop sklearn dependency from RDataLoader Higgs tutorial - #23929
Merged
guitargeek merged 1 commit intoOct 31, 2026
Merged
guitargeek merged 1 commit into
guitargeek merged 1 commit into
Conversation
Right now, the `ml_dataloader_Higgs_Classification.py` tutorial test is failing when sklearn is not installed. The tutorial only used scikit-learn for `roc_curve`, which is a few lines of NumPy. Replace it with a small local helper that is equivalent to `sklearn.metrics.roc_curve(..., drop_intermediate=False)`, so the tutorial can run without scikit-learn installed. Also plot the full ROC curve: the previous code dropped the last point, i.e. the (1, 1) end of the curve. Register the tutorial in the `requires_numpy` fixture list, since it now imports NumPy directly, and in `requires_matplotlib`, which it had always needed but never declared. The alternative to this commit would have been to register the `sklearn` dependency in the `tutorials/CMakeLists.txt`, but reducing the test dependency on external Python packages is also a goal in itself. (cherry picked from commit 6f7cb11)
Test Results 22 files 22 suites 3d 10h 3m 42s ⏱️ For more details on these failures, see this check. Results for commit 90a2aad. |
guitargeek
merged commit Oct 31, 2026
e253aa8
into
root-project:v6-42-00-patches
59 of 65 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23922, requested by @guitargeek.