Repository navigation
Revert "[tutorials] Disable JIT-heavy fit tutorials on Windows 32 bit" - #23930
Conversation
… [ROOT-patch]" I suspect the tutorial was only JIT-heavy because in the original cppjit version in ROOT, it didn't cache some of the wrapper code that can be generated. This situation was improved by the recent improvements in cppjit. This reverts commit 4e1572c.
|
Thanks. Before proceeding with the merge, could perhaps the timing be crosschecked one last time? |
|
@dpiparo, sure! Here is the timings for Windows x64 and x86 before and after cppjit (where the "after cppjit" for x86 is from this PR because it didn't get run before): Windows x64 before cppjit (6.40 nightlies): Windows x64 now (master nightlies): Windows x86 before cppjit (6.40 nightlies): Note that these measurements are quite flaky because of the concurrent ctest. But it seems that these tests in particular didn't seem to have benefited from cppjit, likely because of the fallback to string manipulation and wrapper code generation for the function callback. But at least the timing is in the same ballpark, especially for the x64 nightlies before and after cppjit. So I'd go ahead with this PR! |
Test Results 23 files 23 suites 3d 22h 13m 54s ⏱️ Results for commit 5f86c96. |
|
/backport to 6.42 |
|
Preparing to backport PR #23930 to branch 6.42 requested by guitargeek |
|
This PR has been backported to branch 6.42: #23934 |
I suspect the tutorial was only JIT-heavy because in the original cppjit version in ROOT, it didn't cache some of the wrapper code that can be generated. This situation was improved by the recent improvements in cppjit.
This reverts commit 4e1572c.
FYI @aaronj0