Repository navigation
[DO NOT MERGE][ABI test] lyrical / ABI break: expect "ABI break", failed check (strict), no backport labels - #3386
Closed
fujitatomoya wants to merge 1 commit into
Closed
fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
… on lyrical (ABI break) ABI checker / backport label test; this pull request is closed without merging. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
Expected result
|
ABI Compliance Check❌ Verdict: incompatible
✅
|
fujitatomoya
commented
Oct 27, 2026
fujitatomoya
left a comment
Collaborator
Author
There was a problem hiding this comment.
confirmed expected result, closing.
fujitatomoya
added a commit
that referenced
this pull request
Oct 28, 2026
Verbatim copy of .github/workflows/abi.yaml from rolling (#3262, #3276, ABI check nor the "ABI compatible" / "ABI break" and backport-<distro> labels, because pull_request workflows run from the workflow file of the target branch. Only abi.yaml is needed here: the sticky comment and the labels are published by abi-report.yaml, a workflow_run workflow, which GitHub always runs from the default branch (rolling). The distro and the REP-0009 policy are resolved from the target branch (distro: auto, policy: auto), so the check is strict on lyrical: an incompatible ABI change fails the check. Verified with the same file on test pull request(s) #3385 (compatible) and #3386 (ABI break). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Tomoya.Fujita <fujita.tomoya@triorb.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case: target
lyrical,rclcpp::expand_topic_or_service_name()gains a parameter.Note: this branch has no
abi.yamlyet, so the check only runs on this pull request because thepull request adds a verbatim copy of the rolling
abi.yaml. The sticky comment and labels come fromabi-report.yamlon the default branch (workflow_run), which needs nothing on this branch.This is a test pull request for the ABI checker (
abi.yaml/abi-report.yaml, backed byfujitatomoya/ros2-abi-action) and the
backport-<distro>candidate labels (#2555). It exists only for fujitatomoya to verify theaction result for one specific case, and it is closed without merging once that is done.
Maintainers: nothing to review here, please ignore this pull request.
🤖 Generated with Claude Code