Skip to content

[DO NOT MERGE][ABI test] jazzy / ABI break: expect "ABI break", failed check (strict), no backport labels - #3389

Draft
fujitatomoya wants to merge 1 commit into
jazzyfrom
abi-test/jazzy-break
Draft

fujitatomoya wants to merge 1 commit into
jazzyfrom
abi-test/jazzy-break

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Case: target jazzy, rclcpp::expand_topic_or_service_name() gains a parameter.
Note: this branch has no abi.yaml yet, so the check only runs on this pull request because the
pull request adds a verbatim copy of the rolling abi.yaml. The sticky comment and labels come from
abi-report.yaml on the default branch (workflow_run), which needs nothing on this branch.


This is a test pull request for the ABI checker (abi.yaml / abi-report.yaml, backed by
fujitatomoya/ros2-abi-action) and the
backport-<distro> candidate labels (#2555). It exists only for fujitatomoya to verify the
action result for one specific case, and it is closed without merging once that is done.
Maintainers: nothing to review here, please ignore this pull request.

🤖 Generated with Claude Code

… on jazzy (ABI break)

ABI checker / backport label test; this pull request is closed without merging.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

Expected result

  • abi check: failure (strict policy on a released distro)
  • sticky comment: Verdict: incompatible, librclcpp.so flagged
  • label ABI break added, ABI compatible absent
  • no backport-* label (in particular no backport-humble)

@github-actions

Copy link
Copy Markdown

ABI Compliance Check

❌ Verdict: incompatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ❌ incompatible ABI-incompatible changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ 92b35a8
(empty report — no differences printed by abidiff)
❌ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ 92b35a8
Functions changes summary: 1 Removed, 0 Changed, 1 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 Removed function:

  [D] 'function std::string rclcpp::expand_topic_or_service_name(const std::string&, const std::string&, const std::string&, bool)'    {_ZN6rclcpp28expand_topic_or_service_nameERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES7_S7_b}

1 Added function:

  [A] 'function std::string rclcpp::expand_topic_or_service_name(const std::string&, const std::string&, const std::string&, bool, bool)'    {_ZN6rclcpp28expand_topic_or_service_nameERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES7_S7_bb}


✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ 92b35a8
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ 92b35a8
(empty report — no differences printed by abidiff)

Updated for commit 92b35a8 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant