Repository navigation
Conversation
The slope was computed over the last 30m, which is the whole default run, so the start-up ramp-up of RSS looked like a leak. - analyze_stats.py: use the data after the 10m warm-up (at least the last 5m), based on the real run length from STRESS_START_EPOCH - workflow: record STRESS_START_EPOCH; shortest duration is now 15m (10m warm-up + 5m of data)
Master RSS oscillates by a few hundred MB every ~6 minutes, so the fit over the post-warm-up window keeps some noise. A 30m run measured 13 KB/sec against the old limit of 10 KB/sec.
Two 30m runs measured about 13 and 7 KB/sec after the warm-up; 20 KB/sec was more room than needed.
Collaborator
Author
|
Closing: this fix should go to 3006.x first. I will open a new PR against 3006.x. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The nightly stress test failed on the Master RSS slope (244 KB/sec, limit 10 KB/sec).
analyze_stats.pyfitted the last 30m, which is the whole default run, so the start-up ramp-up of RSS was counted as a leak.STRESS_START_EPOCH. The warm-up can be changed withSTRESS_WARMUP_SECONDS.durationoption is now15m(10m warm-up + 5m of data); it was10m.check_salt_prometheus_metricsnow uses the real run length instead of a fixed 30m.What issues does this PR fix or reference?
Fixes #70677
Notes
Merge requirements satisfied?
CI only: no docs, tests or changelog entry.
Commits signed with GPG?
No