Repository navigation
Conversation
The slope was computed over the last 30m, which is the whole default run, so the start-up ramp-up of RSS looked like a leak. - analyze_stats.py: use the data after the 10m warm-up (at least the last 5m), based on the real run length from STRESS_START_EPOCH. Master RSS limit is 15 KB/sec (was 10): RSS oscillates by a few hundred MB every ~6 minutes, so the fit keeps some noise. - workflow: record STRESS_START_EPOCH; shortest duration is now 15m (10m warm-up + 5m of data)
15m leaves only 5m of data after the warm-up, too little for a meaningful RSS slope. Keep at least the last 10m.
The window is the time after the warm-up, at most the last 30m (the old default), also when the start time of the run is unknown. Long runs are judged on their last 30m so a late leak is not averaged away.
This reverts commit a1666c8.
Collaborator
Author
|
Closing: the leak check is not needed on 3006.x (it does not start fd_exporter, so there is no data). The fix goes to 3008.x in #70683. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The nightly stress test failed on the Master RSS slope (244 KB/sec, limit 10 KB/sec).
analyze_stats.pyfitted the last 30m, which is the whole default run, so the start-up ramp-up of RSS was counted as a leak.STRESS_START_EPOCH. The warm-up can be changed withSTRESS_WARMUP_SECONDS.durationoption is now20m(10m warm-up + 10m of data); it was10m.mastermeasured about 13 and 7 KB/sec.What issues does this PR fix or reference?
Fixes #70677
Notes
master. A 30m run on this branch is queued on my fork and has not finished yet.masterhas a differentanalyze_stats.py(it also hascheck_salt_prometheus_metrics), so merging forward may need a manual resolve.Merge requirements satisfied?
CI only: no docs or tests.
Commits signed with GPG?
No