Repository navigation
sort: preserve 64-bit values and detect temporary-file I/O errors - #2611
Merged
Merged
Conversation
Member
|
This looks OK, and works in my testing. There was a small time penalty of about 3.5% compared to the original code when I forced it to do lots of partial merges by giving it a very small memory buffer. The output was identical though, and there's no difference in time if it doesn't have to do any intermediate merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes assertion failures and coordinate truncation when sorting VCF records with positions beyond the signed 32-bit range.
Also fixes detection of temporary-file read/write errors
Resolves #2043