Repository navigation
feat: implement profanity filtering in suggestions and autocompletion - #746
Open
angrezichatterbox wants to merge 2 commits into
Open
angrezichatterbox wants to merge 2 commits into
angrezichatterbox wants to merge 2 commits into
Conversation
ashb155
reviewed
Nov 4, 2026
| autocompleteRunnable?.let { handler.removeCallbacks(it) } | ||
|
|
||
| if (ime.currentState != ScribeState.IDLE || currentWord.isNullOrEmpty()) { | ||
| if (ime.currentState != ScribeState.IDLE || currentWord.isNullOrEmpty() || |
Collaborator
There was a problem hiding this comment.
needs multi-line condition wrapping here so ktlint passes
ashb155
reviewed
Nov 4, 2026
| ?.filterTo(profanity) { it.isNotEmpty() } | ||
| } | ||
| } | ||
| } catch (e: SQLiteException) { |
Collaborator
There was a problem hiding this comment.
need to update catch block here to prevent SwallowedException detekt issues
ashb155
approved these changes
Nov 4, 2026
ashb155
left a comment
ashb155
left a comment
Collaborator
There was a problem hiding this comment.
apart from issues above rest LGTM @andrewtavis @angrezichatterbox
Member
|
Updated the branch with the latest main, @angrezichatterbox :) |
Member
|
Just triggered an update of Scribe-Server, so when that's done we should have the plurals for profanity coming in :) |
Member
|
Checked and profanity is now included, so we're good to finalize this, @angrezichatterbox! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR remove profane words from autocompletions and autosuggestions
Related issue