Repository navigation
Conversation
|
couple of points @andrewtavis @angrezichatterbox have added applyCapitalizationToStructuredConjugations and getStructuredConjugations to support the new List<Pair<String, String>> contract structure, keeping the legacy applyCapitalizationToConjugations and getTheConjugateLabels functions intaact. should we just remove those or mark them as deprecated? also in a 2x2 grid when only 3 items are present (such as irregular verbs where a category is missing), the 4th slot is currently set to View.INVISIBLE (cell 3 is on the bottom-left, bottom-right is blank). personally i felt bottom one centered would look more aesthetic to the eye. should we keep as is or center the bottom cell? |
|
Just a quick thing, @ashb155: Ideally if we have three options it'd go to a 3x1 view. Would that be possible to implement? |
|
Just a reminder from our conversation, @ashb155, we're talking a stack of three rows for the 3x1 view :) |
current status @andrewtavis @angrezichatterbox , for non-English languages without any sub-menu directly shows on the main selection page
for English main menu no labels as it was causing truncations on few verb main page instance but shows in sub-menu when required as shown below
implemented the 3x1 stack view as well! |




Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the contributing guideDescription
Regarding aligning the keyboard conjugation UI with the Scribe data contract hierarchy:
was being / were being,do / does) now open a sub-menu showing contract person/number labels (e.g.I/he/she/it) and bold forms. Tapping commits only the verb form.View.INVISIBLE.commitTextwith explicit listener callbacks.Related issue