Skip to content

read verb conjugations from contract with sub-menus - #747

Open
ashb155 wants to merge 4 commits into
scribe-org:mainfrom
ashb155:fix/conjugate-contract-submenus
Open

ashb155 wants to merge 4 commits into
scribe-org:mainfrom
ashb155:fix/conjugate-contract-submenus

Conversation

@ashb155

@ashb155 ashb155 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the contributing guide

Description

Regarding aligning the keyboard conjugation UI with the Scribe data contract hierarchy:

  • Sub-selection menus: Multi-form categories (e.g. was being / were being, do / does) now open a sub-menu showing contract person/number labels (e.g. I/he/she/it) and bold forms. Tapping commits only the verb form.
  • Sub-menu navigation: Arrow clicks in sub-menus now back out to the category grid instead of switching tenses.
  • Empty slot fix: Filtered out empty resolved forms so irregular verbs with null entries (like "be") don't leave blank cards. Unused cells are marked View.INVISIBLE.
  • Decoupled input: Replaced string-matching in commitText with explicit listener callbacks.
  • Tests: Added unit tests for structured capitalization, sub-menu display, click behavior, and back navigation.

Related issue

@ashb155

ashb155 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

couple of points @andrewtavis @angrezichatterbox

have added applyCapitalizationToStructuredConjugations and getStructuredConjugations to support the new List<Pair<String, String>> contract structure, keeping the legacy applyCapitalizationToConjugations and getTheConjugateLabels functions intaact. should we just remove those or mark them as deprecated?

also in a 2x2 grid when only 3 items are present (such as irregular verbs where a category is missing), the 4th slot is currently set to View.INVISIBLE (cell 3 is on the bottom-left, bottom-right is blank). personally i felt bottom one centered would look more aesthetic to the eye. should we keep as is or center the bottom cell?

@andrewtavis

Copy link
Copy Markdown
Member

Just a quick thing, @ashb155: Ideally if we have three options it'd go to a 3x1 view. Would that be possible to implement?

@andrewtavis andrewtavis added the -next release- Included in the next release label Nov 6, 2026
@andrewtavis

Copy link
Copy Markdown
Member

Just a reminder from our conversation, @ashb155, we're talking a stack of three rows for the 3x1 view :)

@ashb155

ashb155 commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator Author
image

current status @andrewtavis @angrezichatterbox , for non-English languages without any sub-menu directly shows on the main selection page

image

for English main menu no labels as it was causing truncations on few verb main page instance but shows in sub-menu when required as shown below

image image

implemented the 3x1 stack view as well!

@andrewtavis

Copy link
Copy Markdown
Member

Is looking amazing, @ashb155! Thanks for these extra commits for #750!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-next release- Included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add labels to keyboard conjugation UI options Scribe-Android conjugate functionality is not reading from contract exactly

2 participants