Skip to content

Hide command bar when opening clipboard, emoji palette, or Wikidata info (#749) - #757

Merged
andrewtavis merged 4 commits into
scribe-org:mainfrom
prince-0408:bugfix/command-bar-persistence-749
Nov 11, 2026
Merged

andrewtavis merged 4 commits into
scribe-org:mainfrom
prince-0408:bugfix/command-bar-persistence-749

Conversation

@prince-0408

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

This PR fixes an issue where the command bar persisted and became duplicated with the autosuggestions bar when opening and returning from the clipboard panel, emoji palette, or the Wikidata explanation info panel.

Summary of Changes:

  1. KeyboardUIManager.kt:

    • In showClipboardPanel() and hideClipboardPanel(): explicitly set toolbarBar, invalidInfoBar, and conjugateGridContainer visibility to View.GONE.
    • In showEmojiPalette() and hideEmojiPalette(): ensured toolbarBar, invalidInfoBar, and conjugateGridContainer visibility are set to View.GONE.
    • In showInvalidInfo(): hid toolbarBar (View.GONE) so the command bar no longer sits above the Wikidata pagination view. Also populated binding.invalidText with the invalid command message (e.g. "Not in Wikidata") and applied correct theme colors.
  2. GeneralKeyboardIME.kt & ClipboardHandler.kt:

    • Added moveToIdleState() to openClipboardPanel() and openEmojiKeyboard() so that any in-progress command state is cleanly reset when opening full-screen panels, preventing conflicting states when returning to the normal keyboard.
  3. KeyboardUIManagerTest.kt:

    • Added tests verifying:
      • showClipboardPanel hides toolbarBar and shows clipboardPanelHolder.
      • hideClipboardPanel restores keyboardView and commandOptionsBar while keeping toolbarBar hidden.
      • showInvalidInfo hides toolbarBar and keyboardView, shows invalidInfoBar, and sets invalidText.
      • showEmojiPalette and hideEmojiPalette keep toolbarBar hidden.
  4. CHANGELOG.md:

    • Documented the fix under ### 🐛 Bug Fixes.

Related issue

@andrewtavis

Copy link
Copy Markdown
Member

Great that so many of these issues are being resolved, @prince-0408! We'll take a look at this soon :)

@andrewtavis andrewtavis added the -next release- Included in the next release label Nov 7, 2026

@ashb155 ashb155 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewtavis

Copy link
Copy Markdown
Member

I'll do a review of this later today. Note that we'll continue the styling in #761, as @ashb155 suggested :)

@ashb155 ashb155 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking and working well on my end, @prince-0408! Thanks for getting this major bug fixed! 🐛 Thanks as well for the review, @ashb155!

@andrewtavis
andrewtavis merged commit c3a2925 into scribe-org:main Nov 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-next release- Included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command bar persists in clipboard and can be doubled when returning to the normal UI

3 participants