Repository navigation
Hide command bar when opening clipboard, emoji palette, or Wikidata info (#749) - #757
Merged
andrewtavis merged 4 commits intoNov 11, 2026
Conversation
Member
|
Great that so many of these issues are being resolved, @prince-0408! We'll take a look at this soon :) |
ashb155
reviewed
Nov 9, 2026
ashb155
reviewed
Nov 9, 2026
ashb155
left a comment
Collaborator
There was a problem hiding this comment.
rest LGTM! @andrewtavis @prince-0408
2 tasks done
Member
ashb155
approved these changes
Nov 11, 2026
ashb155
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! @prince-0408 @andrewtavis
andrewtavis
approved these changes
Nov 11, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: All's looking and working well on my end, @prince-0408! Thanks for getting this major bug fixed! 🐛 Thanks as well for the review, @ashb155!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR fixes an issue where the command bar persisted and became duplicated with the autosuggestions bar when opening and returning from the clipboard panel, emoji palette, or the Wikidata explanation info panel.
Summary of Changes:
KeyboardUIManager.kt:showClipboardPanel()andhideClipboardPanel(): explicitly settoolbarBar,invalidInfoBar, andconjugateGridContainervisibility toView.GONE.showEmojiPalette()andhideEmojiPalette(): ensuredtoolbarBar,invalidInfoBar, andconjugateGridContainervisibility are set toView.GONE.showInvalidInfo(): hidtoolbarBar(View.GONE) so the command bar no longer sits above the Wikidata pagination view. Also populatedbinding.invalidTextwith the invalid command message (e.g."Not in Wikidata") and applied correct theme colors.GeneralKeyboardIME.kt&ClipboardHandler.kt:moveToIdleState()toopenClipboardPanel()andopenEmojiKeyboard()so that any in-progress command state is cleanly reset when opening full-screen panels, preventing conflicting states when returning to the normal keyboard.KeyboardUIManagerTest.kt:showClipboardPanelhidestoolbarBarand showsclipboardPanelHolder.hideClipboardPanelrestoreskeyboardViewandcommandOptionsBarwhile keepingtoolbarBarhidden.showInvalidInfohidestoolbarBarandkeyboardView, showsinvalidInfoBar, and setsinvalidText.showEmojiPaletteandhideEmojiPalettekeeptoolbarBarhidden.CHANGELOG.md:### 🐛 Bug Fixes.Related issue