Skip to content

remove command bar misspelled lines - #758

Merged
andrewtavis merged 3 commits into
scribe-org:mainfrom
ashb155:fix/remove-command-bar-misspelled-lines
Nov 8, 2026
Merged

andrewtavis merged 3 commits into
scribe-org:mainfrom
ashb155:fix/remove-command-bar-misspelled-lines

Conversation

@ashb155

@ashb155 ashb155 commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

This pull request resolves an issue where the Android OS spellchecker was drawing red wavy underlines under placeholder and prompt texts (such as en -> es: Ingrese una palabra or foreign language words) in the keyboard's command bar.

image

Related issue

@andrewtavis

Copy link
Copy Markdown
Member

@ashb155: In testing this I'm getting a really weird view for the keyboard where its height is maxed out. This is sadly also on main, which really confuses me as the only PRs that we've brought in, #755 and #756, were for the app menu.

See image below:

Screenshot 2026-11-08 at 02 36 02

The keyboard glitches when you first open it, and then when it does open it has a height of the screen and the keyboard itself is cut off. Testing this on Pixel 9 and API 36 in an emulator.

Would you be able to take a look?

CC @prince-0408 as well. I'm wondering what might be up that this is now happening 🤔

@prince-0408

Copy link
Copy Markdown
Collaborator

@ashb155: In testing this I'm getting a really weird view for the keyboard where its height is maxed out. This is sadly also on main, which really confuses me as the only PRs that we've brought in, #755 and #756, were for the app menu.

See image below:

Screenshot 2026-11-08 at 02 36 02 The keyboard glitches when you first open it, and then when it does open it has a height of the screen and the keyboard itself is cut off. Testing this on Pixel 9 and API 36 in an emulator.

Would you be able to take a look?

CC @prince-0408 as well. I'm wondering what might be up that this is now happening 🤔

Hey @andrewtavis! Neither #755, #756, nor #758 touched keyboard layout code.

It is working completely fine on my device/emulator as well:

Screenshot 2026-11-08 at 7 41 33 AM

This confirms the issue is triggered specifically on API 36 (Android 16) due to system-enforced edge-to-edge window handling:

  1. In KeyboardThemeManager.kt, targetWindow.decorView.setBackgroundColor(color) paints the entire edge-to-edge window decor grey instead of keeping it transparent.
  2. The bottom row gets clipped behind the navigation/gesture bar because navigation insets aren't padded to the keyboard container under edge-to-edge.

I can open a quick PR to fix the IME decorView transparency and insets on API 35/36 if you'd like!

@ashb155

ashb155 commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator Author

@ashb155: In testing this I'm getting a really weird view for the keyboard where its height is maxed out. This is sadly also on main, which really confuses me as the only PRs that we've brought in, #755 and #756, were for the app menu.

See image below:

Screenshot 2026-11-08 at 02 36 02

The keyboard glitches when you first open it, and then when it does open it has a height of the screen and the keyboard itself is cut off. Testing this on Pixel 9 and API 36 in an emulator.

Would you be able to take a look?

CC @prince-0408 as well. I'm wondering what might be up that this is now happening 🤔

could you try restarting the emulator once? It runs fine on my emulator
Medium phobe API 36

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thank you @ashb155 for the contribution and you both for the discussion here! I updated to the latest Android Studio Rabbit 2, and the issue's now been resolved. Great to not have these red lines anymore!

@andrewtavis
andrewtavis merged commit 50f6d6b into scribe-org:main Nov 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mispelled word red lines from command bar placeholder texts

3 participants