Repository navigation
Conversation
ilia-kats
marked this pull request as ready for review
October 30, 2026 12:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as scverse/anndata#2707, but for MuData.
There are several hacks to bypass the sanity checks in anndata's implementation:
attrswith something returning anndata's encoding type and version. This is necessary to be able to pass in a MuData object to anndata's write_use, which happens when writing e.g.MuData.obs,MuData.varetc.obs_names/var_namesof the passed in object, which would be aMuDataobject if using a MuData accessor, so the names don't match what's on disk for the individual modality.Removing the hacks would require making anndata's
write_usemore flexible: Adding a boolean argument to disable encoding type/version checking and adding arguments to pass inobs_namesandvar_namesto check against.The CI is failing due to warnings related to Pandas 3.1. The warnings will disappear with anndata 0.13.5. Everything else is passing (though the new code is not tested in CI yet becase there is no pre-release of anndata 0.14, but the tests pass locally).