Repository navigation
fix: budget required skill reads before loading - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required skill reads can lose instructions when either the shell output or the combined Code Mode response is truncated. Add a two-sentence instruction to the existing Required Skills sections in 18 recipes and 25 subagents: measure files with
wc -c, budget both output layers, split oversized reads upfront, and recover truncated content before proceeding.Bump the patch version from 1.8.4 to 1.8.5.
Validation
npm test: 23 Node tests and 6 Python tests passed.git diff --checkpassed.gpt-6.1-solandhighreasoning effort confirmed the actual model settings, size checks before reads, explicit inner and outer budgets, and received text identical to the complete source files:recipe-plantechnical-designersubagentThe recipe test temporarily removed
allow_implicit_invocation: falsein a disposable copy, then restored it. The subagent test explicitly selected the changed agent definition. These runs cover startup and required-skill loading, not the full planning or design workflow.