Repository navigation
Let a ScrollView take the pull over its whole frame - #541
Merged
marcprux merged 1 commit intoOct 23, 2026
Merged
Conversation
`.refreshable` on a ScrollView is `Modifier.pullRefresh`, a nested-scroll connection that only sees the deltas a scrollable child dispatches. Only the container Box filled; the scrolled Column stayed at its content size. With short content, a pull was therefore accepted only over the content, where a UIScrollView accepts it over its whole frame. Fill the height before making the Column vertically scrollable, as RenderList already does for its LazyColumn. Content taller than the viewport is unaffected: verticalScroll still measures it with an unbounded height. A horizontal ScrollView is left as it was, since the pull is vertical.
Ceylo
marked this pull request as ready for review
October 2, 2026 17:37
Contributor
Author
|
@marcprux I simplified/rewrote the PR description. I hope it's more digest now 🙂 |
Member
Much more digest, thanks! |
marcprux
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
With
.refreshable, pulling bellow the contents inside of aScrollViewdoes nothing. User has to pull specifically on the (potentially short) content. On iOS it works anywhere in the scrollview. This PR brings iOS' behavior to Android.Before / after
A temporary Showcase page,
ScrollView { Text("Refreshes: \(refreshCount)") }.refreshable { refreshCount += 1 }, pulled from below the text and held:After release:
Refreshes: 0before,Refreshes: 1after, in Lite and Fuse.Side effects
DragGestureon theScrollView, or a tap target behind it, no longer receives gestures that start there.Skip Pull Request Checklist:
swift testWritten with Claude Code: the fix, the test and this description. Every claim above comes from a run:
swift test, the mutation run, and the Showcase in Lite and Fuse on an emulator before and after.