Skip to content

Stop ViewThatFits from remeasure-looping after intrinsic queries - #589

Open
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:view-that-fits-grow-fix
Open

dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:view-that-fits-grow-fix

Conversation

@dfabulich

Copy link
Copy Markdown
Member

Compose remeasures any child whose maxIntrinsicWidth was read; if a child is never measured, it remeasures ViewThatFits itself. Measure queried losers in the same pass, and only query the requested axes.

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
    Not required
  • OPTIONAL: I have added an example of any UI changes to the Showcase sample app

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Tested with skiptools/skipapp-showcase#145 and my own app code

* Fixes skiptools#588

Compose remeasures any child whose maxIntrinsicWidth was read; if a child is never measured, it remeasures ViewThatFits itself. Measure queried losers in the same pass, and only query the requested axes.
@cla-bot cla-bot Bot added the cla-signed label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViewThatFits infinite loop when modifying text

1 participant